Fix Gemma image prefill prompt logic and UI#181
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
This pull request fixes the Gemma image prefill prompt logic and updates related UI messages. The changes ensure proper sequencing of settings updates and implement the correct prompt format for Gemma's multimodal capabilities.
Changes:
- Fixed settings update logic to update
currentSettingsFieldsbefore callingsetBackendMode, ensuring media capabilities are determined with the correct model type - Added Gemma-specific prompt formatting methods for multimodal input (pre-image, post-image, and user prompts)
- Updated UI messages to be more generic and consistent (removed model-specific prefixes)
- Implemented proper Gemma multimodal prompt flow with prefill calls before and after image data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ChatViewModel.kt | Fixed settings update sequencing, added Gemma image prefill logic with proper prompt calls, updated UI messages, and added conditional logic for Gemma multimodal user prompts |
| PromptFormat.kt | Added three new methods for Gemma multimodal prompt formatting: pre-image, post-image, and multimodal user prompts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shoumikhin
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #179